Repository navigation
Conversation
DevDenus
reviewed
Oct 18, 2026
| @app.put("/item/{item_id}", response_model=ItemResponse) | ||
| async def put_item(item_id: int, body: ItemPut) -> ItemResponse: | ||
| item = _items.get(item_id) | ||
| if item is None or item.deleted: |
There was a problem hiding this comment.
лучше тут разделить, для несуществующих отдавать 404, а для deleted - 304
| @app.patch("/item/{item_id}", response_model=ItemResponse) | ||
| async def patch_item(item_id: int, body: ItemPatch) -> ItemResponse: | ||
| item = _items.get(item_id) | ||
| if item is None or item.deleted: |
There was a problem hiding this comment.
лучше тут разделить, для несуществующих отдавать 404, а для deleted - 304
| carts = [c for c in carts if sum(i.quantity for i in c.items) >= min_quantity] | ||
| if max_quantity is not None: | ||
| carts = [c for c in carts if sum(i.quantity for i in c.items) <= max_quantity] | ||
| return carts[offset : offset + limit] |
There was a problem hiding this comment.
лучше limit и offset внутри цикла обрабатывать, чтобы лишнего не набирать
| @app.delete("/item/{item_id}") | ||
| async def delete_item(item_id: int) -> dict: | ||
| item = _items.get(item_id) | ||
| if item is not None: |
There was a problem hiding this comment.
для ненайденных по хорошему 404 отдавать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.